Fixing vulnerabilities for `source-salesforce` - Premium support #27899

mauricioalarcon · 2023-06-30T23:45:20Z

CVE-2022-40897
https://security-tracker.debian.org/tracker/CVE-2023-29383
https://security-tracker.debian.org/tracker/CVE-2023-31484
https://security-tracker.debian.org/tracker/CVE-2016-2781

What

Changed source base image to use python:3.9-alpine3.18 instead of slim - Adjusted to update OS packages

How

Switched to use alpine based image

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user?
None expected, just more security

So far nothing breaks and all the test are passing on our side, I've bumped the minor version accordingly

If there are breaking changes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Actions

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Community member? Grant edit access to maintainers (instructions)
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Connector version is set to 0.0.1
- Dockerfile has version 0.0.1
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- docs/integrations/<source or destination>/<name>.md including changelog with an entry for the initial version. See changelog example
- docs/integrations/README.md

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Unit & integration tests added

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

* Source Zendesk Support: fix missing headers

…ehq#27883) * improve words and add doc to sidebar * update words in collecting metrics docs'

…q#27879)

airbytehq#27887)

* changes * update how to pr and readme * update contributeing guides * update code of conduct text * update submit new connector * submit new connector doc * make one line for submit new conn find request * improve words

…eries (airbytehq#27687) * initial ctid for testing * initial ctid for testing * initial ctid for testing * Automated Commit - Format and Process Resources Changes * add version and state type to xmin status * add logic to swtich between xmin and ctid sync * npe fixes * use enum * refactor * add relation node logic + validation for vacuuming + more refactor * refine test + make PR ready for review * remove un-wanted changes * missed this one * remove irrelevant comments * add more assertions * remove jdbc log * address review comments * 🤖 Auto format source-postgres code [skip ci] * skip streams under vacuum * 🤖 Auto format source-postgres code [skip ci] * update log message * 🤖 Auto format source-postgres code [skip ci] * comment * latest round of review comments * missed this file * 🤖 Auto format source-postgres code [skip ci] * initial drop for testing * test * refactor query plan * Add testing for query plan * sanity * sanity * sanity * remove change in spec json * sanity * test * comment * remove hardcoded testing value * add test case * revert json spec * small imrovements * typo * fix test * bump docker image version * revert bump docker image version --------- Co-authored-by: rodireich <rodireich@users.noreply.github.com> Co-authored-by: subodh <subodh1810@gmail.com> Co-authored-by: octavia-squidington-iii <octavia-squidington-iii@users.noreply.github.com> Co-authored-by: Augustin <augustin@airbyte.io>

https://security-tracker.debian.org/tracker/CVE-2023-29383 https://security-tracker.debian.org/tracker/CVE-2023-31484 https://security-tracker.debian.org/tracker/CVE-2016-2781

CLAassistant · 2023-06-30T23:45:26Z

All committers have signed the CLA.

github-actions · 2023-06-30T23:45:38Z

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

PR name follows PR naming conventions
Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
Secrets in the connector's spec are annotated with airbyte_secret
All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
The connector tests are passing in CI
You've updated the connector's metadata.yaml file (new!)
If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

Check for hidden checklists in your PR description
Toggle the github label checklist-action-run on/off to re-run the checklist CI.

sajarin · 2023-07-03T15:38:28Z

@mauricioalarcon can you sign the cla, add an entry to the salesforce.md docs and bump the version in the metadata.yaml file?

marcosmarxm · 2023-07-04T14:30:41Z

airbyte-integrations/connectors/source-salesforce/Dockerfile


 ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

-LABEL io.airbyte.version=2.1.0
+LABEL io.airbyte.version=2.1.1


Can you bump the metadata and documentation changelog? I'll trigger the tests to validate the change.

marcosmarxm · 2023-07-04T18:38:34Z

Running tests in #27954

mauricioalarcon · 2023-07-06T20:30:40Z

Sorry guys @marcosmarxm , @sajarin - while trying to add my email to have the CLA signed ended bringing some other changes - I'm closing this one in favor of #28021 with the same change.

roman-yermilov-gl and others added 10 commits June 30, 2023 21:18

Source Zendesk Support: fix missing headers (airbytehq#27765)

80858ab

* Source Zendesk Support: fix missing headers

add collecting metrics as paid feature doc (airbytehq#27870)

5ed9143

Collecting Metrics docs: improve words and add doc to sidebar (airbyt…

48a8b71

…ehq#27883) * improve words and add doc to sidebar * update words in collecting metrics docs'

make publish_option required in publish connectors workflow (airbyteh…

5898dbe

…q#27879)

Destinations V2: change singleton log message level from warn to debug (

f3600f2

airbytehq#27887)

Docs: update contributing guides (airbytehq#27812)

bac0639

* changes * update how to pr and readme * update contributeing guides * update code of conduct text * update submit new connector * submit new connector doc * make one line for submit new conn find request * improve words

pint to 1.4.1 (airbytehq#27890)

b49b598

Fixing vulnerabilities CVE-2022-40897

9cf9988

https://security-tracker.debian.org/tracker/CVE-2023-29383 https://security-tracker.debian.org/tracker/CVE-2023-31484 https://security-tracker.debian.org/tracker/CVE-2016-2781

Bumped version of the source

c02b17d

octavia-squidington-iii added the area/connectors Connector related issues label Jun 30, 2023

octavia-squidington-iii added community connectors/source/salesforce labels Jun 30, 2023

Merge branch 'master' into PRIS-259-airbyte

578953b

mauricioalarcon marked this pull request as ready for review June 30, 2023 23:45

mauricioalarcon changed the title ~~Fixing vulnerabilities for source-salesforce~~ Fixing vulnerabilities for source-salesforce - Premium support Jun 30, 2023

marcosmarxm added team/connectors-python gl-review labels Jul 3, 2023

marcosmarxm requested changes Jul 4, 2023

View reviewed changes

marcosmarxm added the team/tse Technical Support Engineers label Jul 4, 2023

mauricioalarcon force-pushed the PRIS-259-airbyte branch from 78483ef to 024a3b2 Compare July 6, 2023 20:03

mauricioalarcon requested review from a team as code owners July 6, 2023 20:03

octavia-squidington-iii added area/documentation Improvements or additions to documentation connectors/destination/bigquery-denormalized labels Jul 6, 2023

octavia-squidington-iii added connectors/source/postgres connectors/source/zendesk-support labels Jul 6, 2023

mauricioalarcon force-pushed the PRIS-259-airbyte branch from 024a3b2 to 578953b Compare July 6, 2023 20:06

mauricioalarcon mentioned this pull request Jul 6, 2023

Fixing vulnerabilities for source-salesforce - Premium support #28021

Merged

mauricioalarcon closed this Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixing vulnerabilities for `source-salesforce` - Premium support #27899

Fixing vulnerabilities for `source-salesforce` - Premium support #27899

mauricioalarcon commented Jun 30, 2023

CLAassistant commented Jun 30, 2023 •

edited

Loading

github-actions bot commented Jun 30, 2023

sajarin commented Jul 3, 2023

marcosmarxm Jul 4, 2023

marcosmarxm commented Jul 4, 2023

mauricioalarcon commented Jul 6, 2023

Fixing vulnerabilities for source-salesforce - Premium support #27899

Fixing vulnerabilities for source-salesforce - Premium support #27899

Conversation

mauricioalarcon commented Jun 30, 2023

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Actions

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

CLAassistant commented Jun 30, 2023 • edited Loading

github-actions bot commented Jun 30, 2023

Before Merging a Connector Pull Request

sajarin commented Jul 3, 2023

marcosmarxm Jul 4, 2023

Choose a reason for hiding this comment

marcosmarxm commented Jul 4, 2023

mauricioalarcon commented Jul 6, 2023

Fixing vulnerabilities for `source-salesforce` - Premium support #27899

Fixing vulnerabilities for `source-salesforce` - Premium support #27899

CLAassistant commented Jun 30, 2023 •

edited

Loading